util/agents/usb_hid_relay: fix concurrent access #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since c9fc5bf, it was no longer possible to use the same USB relay device from multiple labgrid processes, as the USB device was kept open and claimed. To fix this, we use a context manager which first claims the USB interface (with retry while busy) and releases it after the transaction. With this fix, multiple processes can toggle outputs in a busy loop without causing 'USBError(16, 'Resource busy')' failures. Fixes: c9fc5bf ("labgrid/util/agents/usb_hid_relay: keep the USB device open") Signed-off-by: Jan Luebbe <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1526 +/- ##
========================================
- Coverage 61.8% 56.7% -5.2%
========================================
Files 166 168 +2
Lines 12305 13022 +717
========================================
- Hits 7605 7384 -221
- Misses 4700 5638 +938 ☔ View full report in Codecov by Sentry. |
Bastian-Krause
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since c9fc5bf, it was no longer possible to use the same USB relay device from multiple labgrid processes, as the USB device was kept open and claimed.
To fix this, we use a context manager which first claims the USB interface (with retry while busy) and releases it after the transaction.
With this fix, multiple processes can toggle outputs in a busy loop without causing 'USBError(16, 'Resource busy')' failures.
Fixes: c9fc5bf ("labgrid/util/agents/usb_hid_relay: keep the USB device open")