Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decrease permissions config.yaml and registries.yaml #165

Merged
merged 2 commits into from
Oct 29, 2023
Merged

decrease permissions config.yaml and registries.yaml #165

merged 2 commits into from
Oct 29, 2023

Conversation

Pionerd
Copy link
Contributor

@Pionerd Pionerd commented Oct 23, 2023

Description

Two files (possibly) containing secrets are currently configured to be world readable:

  • config.yaml contains the secret token for adding nodes to the cluster
  • registries.yaml can possibly contain the password for basic auth registries.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Small minor change not affecting the Ansible Role code (Github Actions Workflow, Documentation etc.)

How Has This Been Tested?

@MonolithProjects MonolithProjects self-assigned this Oct 27, 2023
@MonolithProjects MonolithProjects added the bug Something isn't working label Oct 28, 2023
@MonolithProjects
Copy link
Collaborator

Hi @Pionerd please rebase with main branch. The molecule test failed because of an issue which has been fixed in #166. Thanks

MonolithProjects
MonolithProjects approved these changes Oct 29, 2023
View reviewed changes
Copy link
Collaborator

@MonolithProjects MonolithProjects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@MonolithProjects MonolithProjects merged commit 914f13a into lablabs:main Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonolithProjects MonolithProjects MonolithProjects approved these changes

Assignees

@MonolithProjects MonolithProjects

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pionerd @MonolithProjects