Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add creation of manifests directory before copying kube-vip manifests #176

Merged
merged 1 commit into from
Dec 2, 2023
Merged

fix: Add creation of manifests directory before copying kube-vip manifests #176

merged 1 commit into from
Dec 2, 2023

Conversation

lukapetrovic-git
Copy link
Contributor

Description

Added task to create "{{ rke2_data_path }}/server/manifests" directory before placing kube-vip manifests into it.
Fixes: #175

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Small minor change not affecting the Ansible Role code (Github Actions Workflow, Documentation etc.)

How Has This Been Tested?

Tested in the following scenarios:

  • HA mode enabled + kube-vip enabled + both with and without CNI:
    • Single master with multiple workers - works
    • Multi-master cluster with multiple workers - works

@MonolithProjects MonolithProjects self-assigned this Nov 29, 2023
MonolithProjects
MonolithProjects approved these changes Dec 2, 2023
View reviewed changes
Copy link
Collaborator

@MonolithProjects MonolithProjects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@MonolithProjects MonolithProjects added the bug Something isn't working label Dec 2, 2023
@MonolithProjects MonolithProjects merged commit e556c23 into lablabs:main Dec 2, 2023
6 checks passed
@lukapetrovic-git lukapetrovic-git deleted the fix/FixVIP branch December 15, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonolithProjects MonolithProjects MonolithProjects approved these changes

Assignees

@MonolithProjects MonolithProjects

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Copying of Kube VIP manifests
2 participants
@lukapetrovic-git @MonolithProjects