Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding-IPVS-option #190

Merged
merged 4 commits into from
Feb 8, 2024
Merged

Conversation

strelok899
Copy link
Contributor

@strelok899 strelok899 commented Feb 6, 2024

Description

enabling kube-vip IPVS

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

run on my internal cluster

@strelok899
Copy link
Contributor Author

deployed on my 2 sandbox clusters with great luck using ubuntu 22.04 cloud_img with standard kernel

`Every 2.0s: sudo ipvsadm -lnc master-01-qa-qa: Tue Feb 6 17:48:39 2024

IPVS connection entries
pro expire state source virtual destination
TCP 00:03 CLOSE 10.0.0.1:60937 10.0.0.21:6443 10.0.0.51:6443
TCP 14:53 ESTABLISHED 10.0.0.64:36122 10.0.0.21:6443 10.0.0.61:6443
TCP 00:02 CLOSE 10.0.0.1:60933 10.0.10.0:6443 10.0.0.61:6443
TCP 00:01 CLOSE 10.0.0.1:60928 10.0.10.0:6443 10.0.0.50:6443`

@MonolithProjects MonolithProjects self-requested a review February 7, 2024 08:30
@MonolithProjects
Copy link
Collaborator

Hi @strelok899 could you please rename the variable rke2_kubevip_IPVS_lb_enable to rke2_kubevip_ipvs_lb_enable? I think we should keep all the variables in lower case. But other that that, your PR looks good... Thanks.

@strelok899
Copy link
Contributor Author

Hi @MonolithProjects done

Copy link
Collaborator

@MonolithProjects MonolithProjects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MonolithProjects MonolithProjects merged commit 4a35717 into lablabs:main Feb 8, 2024
5 checks passed
@MonolithProjects MonolithProjects added the enhancement New feature or request label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants