Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Configure default prometheus port in kube vip #194

Merged
merged 2 commits into from
Feb 26, 2024
Merged

feat: Configure default prometheus port in kube vip #194

merged 2 commits into from
Feb 26, 2024

Conversation

koseb9
Copy link
Contributor

@koseb9 koseb9 commented Feb 14, 2024

Description

Explicitly configure the default port for Prometheus to deploy Podmonitor and monitor metrics.

Example:

apiVersion: monitoring.coreos.com/v1
kind: PodMonitor
metadata:
  name: kube-vip
  namespace: kube-system
  labels:
    app.kubernetes.io/name: kube-vip-podmonitor
spec:
  selector:
    matchLabels:
      app.kubernetes.io/name: kube-vip-ds
  podMetricsEndpoints:
    - port: metrics

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Small minor change not affecting the Ansible Role code (Github Actions Workflow, Documentation etc.)

How Has This Been Tested?

We have implemented the modified Kubevip DaemonSet and Podmonitor, and verified the Prometheus targets.

templates/kube-vip/kube-vip.yml.j2 Show resolved Hide resolved
templates/kube-vip/kube-vip.yml.j2 Outdated Show resolved Hide resolved
@MonolithProjects MonolithProjects added the enhancement New feature or request label Feb 22, 2024
Copy link
Collaborator

@MonolithProjects MonolithProjects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MonolithProjects MonolithProjects merged commit 3ef3fb1 into lablabs:main Feb 26, 2024
5 checks passed
@koseb9 koseb9 deleted the kube-vip branch February 27, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants