Fix CIS hardening rke2-cis-sysctl.conf path #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonolithProjects
requested changes
Apr 5, 2024
tasks/cis.yml
Outdated
| @@ -15,7 +15,7 @@ | |||
|
|
|||
| - name: Copy systemctl config file for kernel hardening | |||
| ansible.builtin.copy: | |||
| src: /usr/local/share/rke2/rke2-cis-sysctl.conf | |||
| src: "{{ '/usr/local/share/rke2/rke2-cis-sysctl.conf' if usr_local.stat.writeable == True else '/opt/rke2/share/rke2/rke2-cis-sysctl.conf' }}" | |||
There was a problem hiding this comment.
please remove trailing white space from the end of the line
There was a problem hiding this comment.
Removed trailing whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The CIS hardening currently expects the file to be at
/usr/local/share/rke2/rke2-cis-sysctl.confbut if/usr/localis not writeable it will be at/opt/rke2/share/rke2/rke2-cis-sysctl.conf. This PR simply adds a check if the directory is writeable and adjusts the path accordingly.Type of change
How Has This Been Tested?
Tested locally using molecule and RKE2 v1.27.12+rke2r1