fix: configuration of kube-vip per-service leader election #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously used `enableServicesElection` is not an accepted environment variable but a field in the kube-vip YAML config file. * The related environment variable is `svc_election`, which is already present in the DaemonSet template * Use `rke2_kubevip_service_election_enable` to set the `svc_election` in DaemonSet template * Change default value to `true` to maintain original behavior Signed-off-by: Tomas Nestrojil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously used
enableServicesElectionis not an accepted environment variable but a field in the kube-vip YAML config file.svc_election, which is already present in the DaemonSet templaterke2_kubevip_service_election_enableto set thesvc_electionin DaemonSet templatetrueto maintain original behaviorType of change
How Has This Been Tested?