Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tighten permissions #266

Closed
wants to merge 1 commit into from
Closed

Conversation

simonfelding
Copy link

Description

This tightens security a bit.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Small minor change not affecting the Ansible Role code (GitHub Actions Workflow, Documentation etc.)

How Has This Been Tested?

it works fine

@MonolithProjects MonolithProjects self-assigned this Oct 27, 2024
@MonolithProjects MonolithProjects added the enhancement New feature or request label Oct 27, 2024
@@ -6,7 +6,7 @@
path: /etc/rancher/rke2
owner: root
group: root
mode: 0755
mode: 0750
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifying file and directory permissions to differ from those in the upstream RKE2 installation is not within the scope of this Ansible Role.

@@ -13,4 +13,4 @@
dest: "{{ rke2_data_path }}/server/manifests/rke2-ingress-nginx-config.yaml"
owner: root
group: root
mode: 0664
mode: 0660
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifying file and directory permissions to differ from those in the upstream RKE2 installation is not within the scope of this Ansible Role.

@@ -6,7 +6,7 @@
path: /etc/rancher/rke2
owner: root
group: root
mode: 0755
mode: 0750
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifying file and directory permissions to differ from those in the upstream RKE2 installation is not within the scope of this Ansible Role.

@@ -6,7 +6,7 @@
path: /etc/rancher/rke2
owner: root
group: root
mode: 0755
mode: 0750
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifying file and directory permissions to differ from those in the upstream RKE2 installation is not within the scope of this Ansible Role.

@simonfelding
Copy link
Author

ok makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants