Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ansible_check_mode for 'Run RKE2 install script' #275

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

Raboo
Copy link
Contributor

@Raboo Raboo commented Nov 20, 2024

Description

Currently ansible_check_mode fails for Air-gapped setups.
This fixes ansible_check_mode for 'Run RKE2 install script'.
Also update name of the tasks to make it easier to understand what is running.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Small minor change not affecting the Ansible Role code (GitHub Actions Workflow, Documentation etc.)

How Has This Been Tested?

Tested locally with --check mode against a 3 node cluster that is air-gapped.

Currently ansible_check_mode fails for Air-gapped setups.
This fixes ansible_check_mode for 'Run RKE2 install script'.
Also update name of the tasks.
@MonolithProjects
Copy link
Collaborator

Hi @Raboo, could you please resolve the conflicts?

@Raboo
Copy link
Contributor Author

Raboo commented Nov 25, 2024

@MonolithProjects sure, I've fixed the conflict now.

Copy link
Collaborator

@MonolithProjects MonolithProjects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@MonolithProjects MonolithProjects added the bug Something isn't working label Nov 25, 2024
@MonolithProjects MonolithProjects merged commit d1c6d70 into lablabs:main Nov 25, 2024
6 checks passed
@Raboo Raboo deleted the patch-1 branch November 25, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants