Revert https://github.com/lablabs/ansible-role-rke2/pull/273

[Raboo]

Revert #273. It actually does the opposite of what it says it's trying to achieve

Description

This achieved the opposite. A brand new cluster gets node.cloudprovider.kubernetes.io/uninitialized taint with default settings.

You should remember that rke2_disable_cloud_controller is a negative, i.e. when false it enables the RKE2 cloud controller. When true it disables RKE2 cloud controller.

So the code before #273 PR was correct.

{% if (rke2_disable_cloud_controller | bool ) %}
disable-cloud-controller: true
cloud-provider-name: "{{ rke2_cloud_provider_name }}"
{% endif %}

vs

{% if (rke2_disable_cloud_controller | bool ) %}
disable-cloud-controller: true
{% endif %}
{% if not (rke2_disable_cloud_controller | bool ) %}
cloud-provider-name: "{{ rke2_cloud_provider_name }}"
{% endif %}

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Small minor change not affecting the Ansible Role code (GitHub Actions Workflow, Documentation etc.)

How Has This Been Tested?

Locally on 3 brand new nodes.

[edward2a]

@Raboo please check comments on #273

[MonolithProjects]

LGTM