feat: Update IAM Policy ARNs to Use aws_partition Variable #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unitmatrix
force-pushed
the
use-aws-partition-variable
branch
from
aac418d to
580a71b
Compare
unitmatrix
changed the title
feat(iam): replace static AWS partition with variable for resource ARNs feat(docs): add aws_partition input variable to README
unitmatrix
force-pushed
the
use-aws-partition-variable
branch
from
580a71b to
8151703
Compare
7 tasks
jaygridley
approved these changes
Dec 13, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title:
Update IAM Policy ARNs to Use aws_partition Variable
Description:
This pull request updates the IAM policy ARNs in the Terraform configuration to use the
aws_partitionvariable. This change ensures that the ARNs are dynamically generated based on the specified AWS partition, enhancing compatibility across different AWS environments such as AWS GovCloud and AWS China.Changes:
aws_partitioninvariables.tfwith a default value ofaws.${var.aws_partition}instead of hardcodingaws.These updates improve the flexibility and portability of the Terraform configuration, making it more adaptable to various AWS partitions.
Closes #17
Supersedes #18