-
Notifications
You must be signed in to change notification settings - Fork 13
feat: Display kernel-pull-progress #181
base: main
Are you sure you want to change the base?
feat: Display kernel-pull-progress #181
Conversation
fa7934a
to
ee2851d
Compare
ee2851d
to
f7fafe5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The client.func
module provides a set of functional API wrappers while client.cli
module provides the CLI-specific argument parsing and outputs.
So, could we move the invocation to tqdm
to the cli
module? Of course, the bgtask handling routines must stay here, so we need something like "reporter" interface as in the manager to separate the console output handling and the abstract bgtask handling.
Codecov Report
@@ Coverage Diff @@
## main #181 +/- ##
==========================================
- Coverage 45.46% 45.34% -0.13%
==========================================
Files 74 74
Lines 6801 6815 +14
==========================================
- Hits 3092 3090 -2
- Misses 3709 3725 +16
Continue to review full report at Codecov.
|
When status of the ComputeSession is 'TIMEOUT' or 'PENDING', client prints the info(logs) and return in current code. So, will I implement the code by your feedback in this situations? |
Yes, there was no way to keep track of the kernel preparation process before, so we just printed a messaged and exited. |
But, by your comment, background task handler stays func/session.py and the reporter attribution is added to compute-session? I tried it but in this case, get_or_create method returns after background task is finished. Do I misunderstand? |
41a3d7e
to
8380a5c
Compare
7e8809e
to
171918b
Compare
171918b
to
b93a492
Compare
backend.ai-issue#227
Client (Python & Javascript) Task
Check the existence of the task ID in the create-kernel API response.
If it exists, show a progress bar reflecting its progress stream.
Using response from manager, client obtains background-task pulling kernel and displays progress bar reflecting kernel-pulling. But, I do request twice.
From first request, client obtains kernel_id and background task.
From second request, client gets all the information from existed session.
But, I think we need another way to get all the information(contains background-task id) from manager with a single request.