Skip to content

Commit

Permalink
fix: notarization not working (#2320)
Browse files Browse the repository at this point in the history
  • Loading branch information
kyujin-cho authored Apr 7, 2024
1 parent ff1e179 commit 5b305b2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ jobs:
run: make all
env:
BAI_APP_SIGN: 1
BAI_APP_SIGN_APPLE_TEAM_ID: ${{ secrets.BAI_APP_SIGN_APPLE_TEAM_ID }}
BAI_APP_SIGN_APPLE_ID: ${{ secrets.BAI_APP_SIGN_APPLE_ID }}
BAI_APP_SIGN_APPLE_ID_PASSWORD: ${{ secrets.BAI_APP_SIGN_APPLE_ID_PASSWORD }}
BAI_APP_SIGN_IDENTITY: ${{ secrets.BAI_APP_SIGN_IDENTITY }}
Expand Down
2 changes: 2 additions & 0 deletions app-packager.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ program
program.addOption((new Option('--do-sign', 'Code sign created application with Apple Developer Identity.').env('BAI_APP_SIGN')))
program.addOption((new Option('--sign-apple-id <[email protected]>')).env('BAI_APP_SIGN_APPLE_ID'))
program.addOption((new Option('--sign-apple-id-password <aaaa-bbbb-cccc-dddd>')).env('BAI_APP_SIGN_APPLE_ID_PASSWORD'))
program.addOption((new Option('--sign-apple-team-id <Name of Apple Developer Team ID>')).env('BAI_APP_SIGN_APPLE_TEAM_ID'))
program.addOption((new Option('--sign-identity <Apple Distribution: Example Inc. (AAAAAAAAAA)>')).env('BAI_APP_SIGN_IDENTITY'))
program.addOption((new Option('--sign-keychain <Name of keychain>')).env('BAI_APP_SIGN_KEYCHAIN'))

Expand Down Expand Up @@ -88,6 +89,7 @@ if (selectedOptions.doSign === true && (args[0] === 'mas' || args[0] === 'darwin
options.osxNotarize = {
appleId: selectedOptions.signAppleId,
appleIdPassword: selectedOptions.signAppleIdPassword,
teamId: selectedOptions.signAppleTeamId,
}

console.log(clc.blue('\n[BUILD]') + ` Signing package with identity ${clc.yellow(options.osxSign.identity)}`);
Expand Down

0 comments on commit 5b305b2

Please sign in to comment.