Improve log modal open transition #2944
Assignees
Comments
agatha197
pushed a commit
that referenced
this issue
Dec 12, 2024
Resolves #2944 **Changes:** - Refactored session log modal opening mechanism to use React transitions for smoother loading states - Added proper cleanup of selected kernel when container log modal closes - Improved modal state management by moving logic to a dedicated component **Rationale:** The changes improve the user experience when opening session logs by: - Preventing UI jank during loading with transition states - Ensuring cleaner state management between modal opens/closes **Effects:** Users will experience: - Smoother transitions when opening session logs - More consistent behavior when closing and reopening logs - Better handling of loading states with visual feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The log modal currently does not utilize
useTransitionhook, which can lead to suboptimal user experience. By applying the same method used in PR #2934 , we can achieve a more concise codebase and provide a better UX. When the user clicks, a loading state modal will open more immediately.The text was updated successfully, but these errors were encountered: