refactor: Session log modal transition handling #2943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.24% (-0% 🔻) |
398/7592 |
| 🔴 | Branches | 4.49% (-0% 🔻) |
237/5275 |
| 🔴 | Functions | 3.13% (-0% 🔻) |
78/2494 |
| 🔴 | Lines | 5.16% (-0% 🔻) |
383/7423 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / SessionDetailAndContainerLogOpenerLegacy.tsx |
0% | 0% | 0% | 0% |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from b5b81d7
agatha197
changed the title
Merge activity
|
Resolves #2944 **Changes:** - Refactored session log modal opening mechanism to use React transitions for smoother loading states - Added proper cleanup of selected kernel when container log modal closes - Improved modal state management by moving logic to a dedicated component **Rationale:** The changes improve the user experience when opening session logs by: - Preventing UI jank during loading with transition states - Ensuring cleaner state management between modal opens/closes **Effects:** Users will experience: - Smoother transitions when opening session logs - More consistent behavior when closing and reopening logs - Better handling of loading states with visual feedback
agatha197
force-pushed
the
refactor/session-log-modal-transition-handling
branch
from
a3b20a9 to
b5b81d7
Compare
graphite-app
bot
deleted the
refactor/session-log-modal-transition-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2944
Changes:
Rationale:
The changes improve the user experience when opening session logs by:
Effects:
Users will experience: