-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support vfolder trash bin #2204
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
I'll review this PR after merging lablup/backend.ai#1892 @agatha197 |
feat: rename variables
@agatha197 Please resolve conflicts. |
Done! |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 3.13% (-0% 🔻) |
117/3738 |
🔴 | Branches | 3.56% (-0.01% 🔻) |
87/2447 |
🔴 | Functions | 1.53% (-0% 🔻) |
19/1240 |
🔴 | Lines | 3.08% (-0% 🔻) |
113/3665 |
Test suite run success
32 tests passing in 4 suites.
Report generated by 🧪jest coverage report action from 98bca3b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- fix: remove duplicated code (`this._triggerFolderListChanged();` is called twice because it is included in `this._refreshFolderList()`)
@agatha197 Thank you for the update. It's better than before. Could you improve the messages to include the folder name?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Final screenshots:
resolves #2202
core related PR: lablup/backend.ai#1892
Checklist for reviewers.
delete-pending
status folders are controllable.delete-pending
are disabled. But you can check the info.DEAD_VFOLDER_STATUSES
are listed only in the trash bin tab.delete-pending
.ready
.delete-ongoing
->delete-complete
/delete-error
.delete-complete
, you cannot see the folder info in UI. (you can check with DB).How to test
move this line to line number 677.
backend.ai-webui/src/lib/backend.ai-client-esm.ts
Line 680 in c1b3bb4
Checklist: (if applicable)