-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Session usage monitor in react #2814
base: main
Are you sure you want to change the base?
Conversation
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 5.19% (-0.02% 🔻) |
395/7614 |
🔴 | Branches | 4.48% (-0.05% 🔻) |
237/5289 |
🔴 | Functions | 3.11% (-0.01% 🔻) |
78/2506 |
🔴 | Lines | 5.11% (-0.02% 🔻) |
380/7440 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
---|---|---|---|---|---|
🔴 | ... / SessionUsageMonitor.tsx |
0% | 0% | 0% | 0% |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 3ef88fd
3a48b36
to
8358664
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8358664
to
63bd1b2
Compare
63bd1b2
to
e85e6a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e85e6a4
to
87e4942
Compare
87e4942
to
a1bc1c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found several things that need improvement and discussion. Let's discuss this PR tomorrow.
- Should we include an icon?
- Should the progress bar be larger?
- How can we make it usable in the columns of the session list neo?
- There are incorrect labels and units.
a1bc1c6
to
c15e3d9
Compare
c15e3d9
to
ca597df
Compare
ca597df
to
3ef88fd
Compare
The size property of progressProps or showIcon can be used to modify the visibility of the icon or the size of the progress bar. |
This PR resolves #2803 issue.
Changes:
How to test:
Checklist: (if applicable)