Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: suppress Relay warning messages in development mode #2852

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Nov 15, 2024

Suppress Relay GraphQL Field Warning Messages in Development

This change filters out frequent Relay warning messages in the browser console during development. These warnings occur due to GraphQL query directives used for manager version compatibility and do not indicate actual issues.

The warnings specifically relate to "RelayResponseNormalizer: Payload did not contain a value for field" messages, which are expected behavior but can clutter the development console.

image.png

Checklist:

  • Test case(s) to demonstrate the difference of before/after
    • Before: Console shows repeated Relay field warnings
    • After: These specific warnings are suppressed while preserving other console messages

Copy link

graphite-app bot commented Nov 15, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the size:S 10~30 LoC label Nov 15, 2024
Copy link

github-actions bot commented Nov 15, 2024

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
5.29% (-0% 🔻)
395/7468
🔴 Branches
4.58% (-0.01% 🔻)
237/5172
🔴 Functions
3.16% (-0% 🔻)
78/2467
🔴 Lines
5.2% (-0% 🔻)
380/7301

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from e7f125e

@yomybaby yomybaby requested a review from lizable November 15, 2024 01:44
@yomybaby yomybaby marked this pull request as ready for review November 15, 2024 01:44
@yomybaby yomybaby requested a review from ironAiken2 November 21, 2024 10:34
@yomybaby yomybaby force-pushed the chore/suppress-relays-no-contain-warning branch from 2c405a7 to e7f125e Compare November 22, 2024 08:56
Copy link
Contributor

@lizable lizable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, though, there are some warning msg remaining. Let's merge it first to prevent endless conflicts, for now.

@yomybaby yomybaby merged commit a6cde1a into main Nov 25, 2024
8 checks passed
@yomybaby yomybaby deleted the chore/suppress-relays-no-contain-warning branch November 25, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S 10~30 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants