add: option to show/hide agent select option by launcher #2870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.29% | 395/7468 |
| 🔴 | Branches | 4.58% (-0% 🔻) |
237/5173 |
| 🔴 | Functions | 3.16% | 78/2467 |
| 🔴 | Lines | 5.2% | 380/7301 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 3f18c86
yomybaby
requested changes
Nov 21, 2024
lizable
force-pushed
the
feature/add-option-to-show-or-hide-agent-select-option-in-launcher
branch
from
916a5df to
0e5d3ae
Compare
github-actions
bot
added
field:UI / UX
type:fix
yomybaby
requested changes
Nov 22, 2024
lizable
force-pushed
the
feature/add-option-to-show-or-hide-agent-select-option-in-launcher
branch
from
0e5d3ae to
c897bb1
Compare
lizable
force-pushed
the
feature/add-option-to-show-or-hide-agent-select-option-in-launcher
branch
from
c897bb1 to
b7511dc
Compare
Merge activity
|
This PR resolves [#2837](#2837) **Changes:** Makes agent selection in resource allocation form configurable via a new `enableAgentSelect` prop, defaulting to false. The agent selection field will only display when both `enableAgentSelect` is true and `baiClient._config.hideAgents` is false. **Implementation:** - Added `enableAgentSelect` prop to ResourceAllocationFormItems component - Set `enableAgentSelect` to true in SessionLauncherPage to maintain existing behavior - Agent selection field visibility now requires both configuration flags to be properly set **Testing Steps:** > Prerequisites: > - Create model type vfolder > - Create model-definition.yaml file and upload it to the vfolder you just created in step 1, according to the link [here](https://webui.docs.backend.ai/en/latest/model_serving/model_serving.html#guide-to-steps-for-using-model-service) 1. Set `hideAgents` in config.general to false. 2. Go to Session launcher page and check AgentSelect section is visible. 3. Check whether you can select agent and create a session which is located to the agent you just selected. 4. Go to Service launcher page by clicking `Start Service` button in Serving page and check AgentSelect section is invisible. 5. Check whether service is successfully created **Checklist:** - [ ] Mention to the original issue - [ ] Documentation - [ ] Minimum required manager version - [ ] Specific setting for review - [ ] Minimum requirements to check during review - [x] Test case(s) to demonstrate the difference of before/after
yomybaby
force-pushed
the
feature/add-option-to-show-or-hide-agent-select-option-in-launcher
branch
from
b7511dc to
3f18c86
Compare
graphite-app
bot
deleted the
feature/add-option-to-show-or-hide-agent-select-option-in-launcher
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #2837
Changes:
Makes agent selection in resource allocation form configurable via a new
enableAgentSelectprop, defaulting to false. The agent selection field will only display when bothenableAgentSelectis true andbaiClient._config.hideAgentsis false.Implementation:
enableAgentSelectprop to ResourceAllocationFormItems componentenableAgentSelectto true in SessionLauncherPage to maintain existing behaviorTesting Steps:
hideAgentsin config.general to false.Start Servicebutton in Serving page and check AgentSelect section is invisible.Checklist: