fix: password is removed from DB if registry is modified without checking the change password option #2875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.27% (-0.01% 🔻) |
395/7491 |
| 🔴 | Branches | 4.57% (-0.01% 🔻) |
237/5182 |
| 🔴 | Functions | 3.16% (-0% 🔻) |
78/2471 |
| 🔴 | Lines | 5.19% (-0.01% 🔻) |
380/7323 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from a37c79c
agatha197
commented
Nov 24, 2024
github-actions
bot
added
field:UI / UX
type:fix
Merge activity
|
agatha197
added
urgency:blocker
Graphite App
github-actions
bot
added
the
urgency:3
yomybaby
requested changes
Nov 25, 2024
agatha197
force-pushed
the
fix/password-is-removed-when-modifying
branch
2 times, most recently
from
457c15c to
93f2faa
Compare
…king the change password option (#2875) resolves #2874 **Changes:** Added a new mutation `ContainerRegistryEditorModalModifyWithoutPasswordMutation` to handle registry modifications when the password remains unchanged. This prevents sending unnecessary password data during updates. **Implementation Details:** - Created a separate mutation path for registry modifications without password changes - Updated the `handleSave` function to use the appropriate mutation based on whether the password was modified - Added loading state tracking for the new mutation in the modal's confirm button **Rationale:** This change improves security by not transmitting password data when it hasn't been modified, following the principle of least privilege. **Checklist:** - [x] Mention to the original issue - [ ] Documentation - [x] Minium required manager version: 24.09 - [x] Specific setting for review: refer issue - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after **Testing Requirements:** 1. Verify registry updates work when password is not modified 2. Confirm password updates still function when modified 3. Check error handling for both mutation paths
agatha197
force-pushed
the
fix/password-is-removed-when-modifying
branch
from
93f2faa to
a37c79c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2874
Changes:
Added a new mutation
ContainerRegistryEditorModalModifyWithoutPasswordMutationto handle registry modifications when the password remains unchanged. This prevents sending unnecessary password data during updates.Implementation Details:
handleSavefunction to use the appropriate mutation based on whether the password was modifiedRationale:
This change improves security by not transmitting password data when it hasn't been modified, following the principle of least privilege.
Checklist:
Testing Requirements: