fix: use combine operator & and |`
#2938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.25% (-0% 🔻) |
398/7587 |
| 🔴 | Branches | 4.5% (-0% 🔻) |
237/5271 |
| 🔴 | Functions | 3.13% | 78/2492 |
| 🔴 | Lines | 5.16% (-0% 🔻) |
383/7418 |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / BAIPropertyFilter.tsx |
11.11% (-0.16% 🔻) |
0% | 3.85% | 11.94% (-0.18% 🔻) |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 8252a10
Merge activity
|
Resolves #2939 **Changes:** Updates the filter combination logic in BAIPropertyFilter to: - Return `undefined` instead of empty string when merging empty filter values - Change operator types from 'and'/'or' to '&'/'|' to match backend expectations - Standardize filter combination to use '&' operator consistently
ironAiken2
force-pushed
the
fix/bai-property-filter-operation
branch
from
ab9b64b to
8252a10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2939
Changes:
Updates the filter combination logic in BAIPropertyFilter to:
undefinedinstead of empty string when merging empty filter values