Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change the layout page of model store with random image #2950

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lizable
Copy link
Contributor

@lizable lizable commented Dec 13, 2024

Changes:
This PR partially resolves backend.ai-internal#110
Redesigned the model store list page layout with the following updates:

  • Fixed grid layout to consistently show 2 columns
  • Added image placeholders for model cards
  • Improved description layout with image and text side by side
  • Reorganized tag display for better visual hierarchy

Rationale:
The new layout provides a more consistent and visually appealing presentation of model information, making it easier for users to scan and compare different models.

Checklist:

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Review Notes:
Please verify:

  1. Grid layout displays correctly with 2 columns
  2. Image placeholders load properly
  3. Description text wraps appropriately next to images
  4. Tags and error messages render correctly in the new layout

@github-actions github-actions bot added the size:L 100~500 LoC label Dec 13, 2024
Copy link
Contributor Author

lizable commented Dec 13, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
5.25% (+0% 🔼)
398/7587
🔴 Branches
4.5% (+0.01% 🔼)
237/5269
🔴 Functions
3.13% (+0% 🔼)
78/2492
🔴 Lines
5.16% (+0% 🔼)
383/7418
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / ComputeSessionList.tsx
0%
0% (-100% 🔻)
0% 0%

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from c3916c3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L 100~500 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant