Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reliable VFolder deletion(purge) #1797

Open
Tracked by #767
fregataa opened this issue Dec 19, 2023 · 0 comments
Open
Tracked by #767

Reliable VFolder deletion(purge) #1797

fregataa opened this issue Dec 19, 2023 · 0 comments
Assignees
Labels
comp:manager Related to Manager component comp:storage-proxy Related to Storage proxy component type:enhance Enhance component, behavior, internals without user-facing features urgency:5 It is imperative that action be taken right away.
Milestone

Comments

@fregataa
Copy link
Member

fregataa commented Dec 19, 2023

Current version: main(before release 24.03.0)

Currently, the vfolder deletion task is run by aiotools.PersistentTaskGroup.
The steps of the task is like below

  1. Update status value of DB vfolders table to PURGE_ONGOING.
  2. Request folder deletion to each storage proxy.
  3. Delete records of DB vfolders table that has been successfully deleted.

The clients do not get informed when any error occurs during this long-term tasks.
There are several ways to resolve this issue.

  • Use BackgroundTask and its server-side response
  • Convert folder deletion from blocking response to event-driven pattern (using Redis)
  • Update vfolder name before delete-forever to allow creating a new vfolder with the same name

Please leave any other idea.

Related issues:

@fregataa fregataa self-assigned this Jan 25, 2024
@achimnol achimnol added comp:manager Related to Manager component comp:storage-proxy Related to Storage proxy component type:enhance Enhance component, behavior, internals without user-facing features labels Feb 28, 2024
@achimnol achimnol added this to the 24.03 milestone Feb 28, 2024
@fregataa fregataa modified the milestones: 24.03, 24.09 May 8, 2024
@fregataa fregataa modified the milestones: 24.09, 24.12 Nov 7, 2024
@inureyes inureyes added the urgency:5 It is imperative that action be taken right away. label Nov 7, 2024
@fregataa fregataa removed this from the 24.12 milestone Nov 8, 2024
@HyeockJinKim HyeockJinKim added this to the 24.12 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component comp:storage-proxy Related to Storage proxy component type:enhance Enhance component, behavior, internals without user-facing features urgency:5 It is imperative that action be taken right away.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants