Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Delete vfolder in bgtask #2739

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Aug 20, 2024

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

📚 Documentation preview 📚: https://sorna--2739.org.readthedocs.build/en/2739/


📚 Documentation preview 📚: https://sorna-ko--2739.org.readthedocs.build/ko/2739/

Copy link
Member Author

fregataa commented Aug 20, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fregataa and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added area:docs Documentations comp:manager Related to Manager component size:L 100~500 LoC labels Aug 20, 2024
@fregataa fregataa force-pushed the topic/08-20-feat_add_log_level_to_background_task_message branch from 6aea086 to c0d9a00 Compare August 20, 2024 08:35
@fregataa fregataa force-pushed the topic/08-19-feat_run_vfolder_deletion_on_bgtask branch from 157dace to 1776b34 Compare August 20, 2024 08:36
@fregataa fregataa force-pushed the topic/08-20-feat_add_log_level_to_background_task_message branch from c0d9a00 to eb2eba0 Compare August 20, 2024 08:49
@fregataa fregataa mentioned this pull request Aug 20, 2024
2 tasks
@fregataa fregataa force-pushed the topic/08-19-feat_run_vfolder_deletion_on_bgtask branch from 1776b34 to 97c8ec4 Compare August 20, 2024 08:49
@fregataa fregataa force-pushed the topic/08-20-feat_add_log_level_to_background_task_message branch from eb2eba0 to ea42f4a Compare August 20, 2024 09:19
@fregataa fregataa force-pushed the topic/08-19-feat_run_vfolder_deletion_on_bgtask branch from 97c8ec4 to 0466662 Compare August 20, 2024 09:19
@fregataa fregataa force-pushed the topic/08-20-feat_add_log_level_to_background_task_message branch from ea42f4a to e563a3c Compare November 9, 2024 03:46
@fregataa
Copy link
Member Author

fregataa commented Nov 9, 2024

In #3060, we decided to convert folder deletion from blocking response to event-driven pattern rather than applying bgtask.

@fregataa fregataa closed this Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Documentations comp:manager Related to Manager component size:L 100~500 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant