Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add log-level to background task message #2738

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Aug 20, 2024

Let's add log_level field to background task event.
Current implementation of bgtask updates its progress with number type current & total progress and string type message.
Such implementation cannot inform clients of a granular failure of the total bgtask through progress reporter.
e.g. A task deleting multiple vfolders has failed to delete a few of them.

Adding log_level field could resolve this issue.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

Copy link
Member Author

fregataa commented Aug 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added comp:common Related to Common component size:S 10~30 LoC labels Aug 20, 2024
@fregataa fregataa force-pushed the topic/08-19-feat_apply_semaphore_and_file-lock_on_folder_deletion branch from e638f83 to ee7792f Compare August 20, 2024 08:35
@fregataa fregataa force-pushed the topic/08-20-feat_add_log_level_to_background_task_message branch from 6aea086 to c0d9a00 Compare August 20, 2024 08:35
@fregataa fregataa force-pushed the topic/08-19-feat_apply_semaphore_and_file-lock_on_folder_deletion branch from ee7792f to be917b0 Compare August 20, 2024 08:48
@fregataa fregataa force-pushed the topic/08-20-feat_add_log_level_to_background_task_message branch from c0d9a00 to eb2eba0 Compare August 20, 2024 08:49
@fregataa fregataa mentioned this pull request Aug 20, 2024
2 tasks
@fregataa fregataa force-pushed the topic/08-20-feat_add_log_level_to_background_task_message branch from eb2eba0 to ea42f4a Compare August 20, 2024 09:19
@fregataa fregataa changed the base branch from topic/08-19-feat_apply_semaphore_and_file-lock_on_folder_deletion to main August 20, 2024 09:19
@fregataa fregataa added the skip:changelog Make the action workflow to skip towncrier check label Aug 20, 2024
@fregataa fregataa added this to the 24.09 milestone Aug 20, 2024
@fregataa fregataa marked this pull request as ready for review August 20, 2024 09:32
@fregataa fregataa modified the milestones: 24.09, 24.12 Oct 21, 2024
@fregataa fregataa force-pushed the topic/08-20-feat_add_log_level_to_background_task_message branch from ea42f4a to e563a3c Compare November 9, 2024 03:46
@HyeockJinKim
Copy link

It seems better to manage this by creating code for the task results.
Additionally, the warning log should be logged where the failure occurs, not in the reporter.
We need to think of a way to pass the bg_task id values.

Please create an epic issue for both tasks. @fregataa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:common Related to Common component size:S 10~30 LoC skip:changelog Make the action workflow to skip towncrier check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants