Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup: Upgrade the base Python version from 3.11.3 to 3.11.4 #1431

Merged
merged 22 commits into from
Jul 31, 2023

Conversation

inureyes
Copy link
Member

@inureyes inureyes commented Jul 27, 2023

Bump the base Python version (3.11.3 → 3.11.4) to resolve potential bugs.

Also:

  • Upgrade redis-py (4.5.5 → 4.6.0)
  • Upgrade lark (lark-parser 0.11.3 → lark 1.1.5; package is renamed)
  • Stabilize flakky test cases (especially tests/common/redis) by ensuring the TCP ports used by fixture containers to become free
    • They are allocated using the parallel execution slot numbers and theorectically there should be no conflicts. But in GitHub Actions, they seem to remain open for a short period of time (randomly) even after terminating the containers. It may be because Docker uses a proxy process for each bound container port and repeating creation/destruction of containers for many times in paralllel seems to cause unexpected random delays to clear up them.

Development guide

$ pyenv update
# or
$ cd ~/.pyenv && git pull && cd workdir

$ pyenv install 3.11.4
# or
$ CONFIGURE_OPTS='--enable-optimizations' pyenv install 3.11.4

$ pants export --resolve=python-default --resolve=python-kernel --resolve=black --resolve=isort --resolve=flake8 --resolve=mypy

# update your IDE settings as necessary, like:
$ edit .vim/coc-settings.json
$ edit .vscode/settings.json

@inureyes inureyes self-assigned this Jul 27, 2023
@github-actions github-actions bot added the size:XL 500~ LoC label Jul 27, 2023
@inureyes inureyes changed the title update: base python version from 3.11.4 to 3.11.4 update: base python version from 3.11.3 to 3.11.4 Jul 27, 2023
@inureyes inureyes added this to the 23.03 milestone Jul 27, 2023
@inureyes inureyes added type:maintenance Maintenance issue. comp:common Related to Common component area:upstream Issues with root cause from upstream 3rd parties effort:hard Need to understand many components / a large extent of contextual or historical information. impact:invisible This change is invisible to users (internal changes). platform:general General platform issues. Most issues are general. urgency:3 Must be finished within a certain time frame. and removed size:XL 500~ LoC labels Jul 27, 2023
@inureyes inureyes requested a review from achimnol July 27, 2023 13:11
@inureyes inureyes marked this pull request as ready for review July 27, 2023 13:11
@github-actions github-actions bot added comp:client Related to Client component comp:manager Related to Manager component comp:storage-proxy Related to Storage proxy component require:db-migration Automatically set when alembic migrations are added or updated size:XL 500~ LoC labels Jul 27, 2023
@achimnol achimnol enabled auto-merge July 27, 2023 14:00
@achimnol achimnol changed the title update: base python version from 3.11.3 to 3.11.4 setup: Upgrade the base python version from 3.11.3 to 3.11.4 Jul 27, 2023
@achimnol achimnol changed the title setup: Upgrade the base python version from 3.11.3 to 3.11.4 setup: Upgrade the base Python version from 3.11.3 to 3.11.4 Jul 27, 2023
@achimnol achimnol added this pull request to the merge queue Jul 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 27, 2023
@achimnol achimnol added this pull request to the merge queue Jul 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 29, 2023
@achimnol achimnol enabled auto-merge July 30, 2023 15:59
@achimnol achimnol disabled auto-merge July 30, 2023 16:00
@achimnol achimnol added this pull request to the merge queue Jul 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 30, 2023
@achimnol achimnol removed the require:db-migration Automatically set when alembic migrations are added or updated label Jul 31, 2023
@achimnol
Copy link
Member

require:db-migration is a bogus label because this PR's update changes the black formatting style affecting some files in the alembic migrations folder.

@achimnol achimnol added this pull request to the merge queue Jul 31, 2023
Merged via the queue into main with commit 27264f2 Jul 31, 2023
29 checks passed
@achimnol achimnol deleted the update/base-python-to-3-11-4 branch July 31, 2023 02:46
achimnol added a commit that referenced this pull request Jul 31, 2023
Backported-from: main
Backported-to: 23.03

Co-authored-by: Joongi Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:upstream Issues with root cause from upstream 3rd parties comp:client Related to Client component comp:common Related to Common component comp:manager Related to Manager component comp:storage-proxy Related to Storage proxy component effort:hard Need to understand many components / a large extent of contextual or historical information. impact:invisible This change is invisible to users (internal changes). platform:general General platform issues. Most issues are general. size:XL 500~ LoC type:maintenance Maintenance issue. urgency:3 Must be finished within a certain time frame.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants