-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Replace sessions
, kernels
's status_history
's type map
with list
#1662
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:client
Related to Client component
comp:manager
Related to Manager component
size:L
100~500 LoC
labels
Oct 27, 2023
jopemachine
changed the title
fix: Change status_history from map to list
fix: Change Oct 27, 2023
status_history
from map to list
jopemachine
changed the title
fix: Change
fix: Replace Oct 27, 2023
status_history
from map to liststatus_history
's type map
with list
jopemachine
added
the
require:db-migration
Automatically set when alembic migrations are added or updated
label
Oct 27, 2023
github-actions
bot
added
size:XL
500~ LoC
size:L
100~500 LoC
and removed
size:L
100~500 LoC
size:XL
500~ LoC
labels
Oct 30, 2023
jopemachine
force-pushed
the
fix/status-history
branch
2 times, most recently
from
January 26, 2024 11:22
f73d02d
to
a94fc0f
Compare
jopemachine
changed the title
fix: Replace
fix: Replace Feb 28, 2024
status_history
's type map
with list
session
, kernel
's status_history
's type map
with list
jopemachine
changed the title
fix: Replace
fix: Replace Feb 28, 2024
session
, kernel
's status_history
's type map
with list
sessions
, kernels
's status_history
's type map
with list
We also need to update clients using the session resource usage API handler's
as this does not go through the GraphQL's backward-compatible field generation. |
jopemachine
force-pushed
the
fix/status-history
branch
from
May 3, 2024 02:32
6c5da4b
to
bdfd636
Compare
github-actions
bot
added
area:docs
Documentations
comp:common
Related to Common component
comp:cli
Related to CLI component
labels
May 3, 2024
achimnol
requested changes
May 3, 2024
2 tasks
jopemachine
force-pushed
the
fix/status-history
branch
from
May 7, 2024 04:36
e10af21
to
cf8a6d0
Compare
jopemachine
changed the title
fix: Replace
refactor: Replace May 7, 2024
sessions
, kernels
's status_history
's type map
with list
sessions
, kernels
's status_history
's type map
with list
2 tasks
Switching to another PR as we introduce Graphite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:docs
Documentations
comp:cli
Related to CLI component
comp:client
Related to Client component
comp:common
Related to Common component
comp:manager
Related to Manager component
require:db-migration
Automatically set when alembic migrations are added or updated
size:XL
500~ LoC
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #412, follow-up to #480.
Related issue: #1116.
The current implementation saves only the most recent timestamp whenever status information in
status_history
is updated, and all previous information is deleted.This PR prevents the loss of timestamp information by changing the data structure of
sessions
,kernels
'sstatus_history
to List.Previous format:
New format:
Checklist: (if applicable)
📚 Documentation preview 📚: https://sorna--1662.org.readthedocs.build/en/1662/
📚 Documentation preview 📚: https://sorna-ko--1662.org.readthedocs.build/ko/1662/