-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Compare image memory limit to sum of shmem and main mem #1770
base: main
Are you sure you want to change the base?
Conversation
17a1621
to
3d6ae68
Compare
I'm going to hold this PR because the calculation method change will break existing API users (now we have serious ones) and complicates which values to store in the scheduler. EDIT: |
…e overriding requested_slots["mem"]
Co-authored-by: Kyujin Cho <[email protected]>
79a5c45
to
245de35
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
raise InvalidAPIParameters( | ||
f"Too large shared memory. Maximum ratio of 'shared memory / memory' is {str(allowed_max_shmem_ratio)}. " | ||
f"(s:{str(shmem)}, m:{str(BinarySize(requested_slots["mem"]))}" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error message string is missing a closing parenthesis. The line should be:
f"(s:{str(shmem)}, m:{str(BinarySize(requested_slots['mem']))})"
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
resolves #1726
This makes the behavior of the backend's interpretation of "mem" ($M$ ) and "shmem" ($S$ ) values consistent with the Web UI, which passes them as $(M-S, S)$ instead of $(M, S)$ .
ai.backend.resource.min.mem
with the sum of main memory size and shared memory size instead of main memory size.Checklist: (if applicable)