Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Query inconsistencies and mistakes in the vfolder share/change-ownership API handlers #1850

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

mirageoasis
Copy link
Collaborator

@mirageoasis mirageoasis commented Jan 19, 2024

fix of vfolder query while making audit_logs

  1. share
    ACTIVE_USER_STATUSES is tuple so fixed operator from == to in

  2. chage_vfolder_options
    there was inconsistency between update and select statement which look for folder to update

@github-actions github-actions bot added the comp:manager Related to Manager component label Jan 19, 2024
@github-actions github-actions bot added the size:S 10~30 LoC label Jan 19, 2024
@mirageoasis mirageoasis changed the title fix : fix errors in vfolder query fix: fix errors in vfolder query Jan 22, 2024
@achimnol achimnol changed the title fix: fix errors in vfolder query fix: Query inconsistencies and mistakes in the vfolder share/change-ownership API handlers Jan 30, 2024
@achimnol achimnol added the type:bug Reports about that are not working label Jan 30, 2024
@achimnol achimnol added this to the 23.09 milestone Jan 30, 2024
@achimnol achimnol added this pull request to the merge queue Jan 30, 2024
Merged via the queue into main with commit 9348389 Jan 30, 2024
33 of 40 checks passed
@achimnol achimnol deleted the fix/vfolder-query-fix branch January 30, 2024 08:05
achimnol added a commit that referenced this pull request Jan 30, 2024
…wnership API handlers (#1850)

Backported-from: main (24.03)
Backported-to: 23.09
Co-authored-by: Joongi Kim <[email protected]>
mirageoasis added a commit that referenced this pull request Jan 31, 2024
fregataa pushed a commit that referenced this pull request Feb 4, 2024
kyujin-cho pushed a commit that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component size:S 10~30 LoC type:bug Reports about that are not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants