fix: Modify help text for delete and purge domain #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achimnol
requested changes
Feb 19, 2024
achimnol
added
skip:changelog
This is what I agree with. |
achimnol
approved these changes
May 3, 2024
Merge activity
|
Domain's purge help text explains delete. Of course, delete and purge are words used with similar meanings, but there is a command called domain delete, which can confuse users. ``` Delete the given virtual folder. Purge the given virtual folder. ``` I modified it by referring to the vfolder delete and purge help phrases above. **Checklist:** (if applicable) - [x] Milestone metadata specifying the target backport version - [ ] Mention to the original issue - [ ] Installer updates including: - Fixtures for db schema changes - New mandatory config options - [ ] Update of end-to-end CLI integration tests in `ai.backend.test` - [ ] API server-client counterparts (e.g., manager API -> client SDK) - [ ] Test case(s) to: - Demonstrate the difference of before/after - Demonstrate the flow of abstract/conceptual models with a concrete implementation - [ ] Documentation - Contents in the `docs` directory - docstrings in public interfaces and type annotations
jopemachine
pushed a commit
that referenced
this pull request
May 7, 2024
Domain's purge help text explains delete. Of course, delete and purge are words used with similar meanings, but there is a command called domain delete, which can confuse users. ``` Delete the given virtual folder. Purge the given virtual folder. ``` I modified it by referring to the vfolder delete and purge help phrases above. **Checklist:** (if applicable) - [x] Milestone metadata specifying the target backport version - [ ] Mention to the original issue - [ ] Installer updates including: - Fixtures for db schema changes - New mandatory config options - [ ] Update of end-to-end CLI integration tests in `ai.backend.test` - [ ] API server-client counterparts (e.g., manager API -> client SDK) - [ ] Test case(s) to: - Demonstrate the difference of before/after - Demonstrate the flow of abstract/conceptual models with a concrete implementation - [ ] Documentation - Contents in the `docs` directory - docstrings in public interfaces and type annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Domain's purge help text explains delete.
Of course, delete and purge are words used with similar meanings, but there is a command called domain delete, which can confuse users.
I modified it by referring to the vfolder delete and purge help phrases above.
Checklist: (if applicable)
ai.backend.testdocsdirectory