Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: new VFolder ID-based API #1926

Closed
wants to merge 22 commits into from
Closed

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Feb 22, 2024

resolves #1905

New VFolder API

TODO

  • Refactor vfolder_permission_required, ensure_vfolder_status and query_accessible_vfolders

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

@fregataa fregataa added this to the 24.03 milestone Feb 22, 2024
@fregataa fregataa self-assigned this Feb 22, 2024
@github-actions github-actions bot added comp:manager Related to Manager component size:XL 500~ LoC labels Feb 22, 2024
@fregataa fregataa marked this pull request as ready for review February 26, 2024 05:53
@fregataa fregataa marked this pull request as draft February 26, 2024 06:06
@fregataa fregataa modified the milestones: 24.03, 24.09 Apr 23, 2024
@github-actions github-actions bot added the comp:cli Related to CLI component label Apr 23, 2024
@fregataa fregataa requested a review from achimnol April 23, 2024 13:25
@fregataa fregataa changed the title refactor: new VFolder ID-based API chore: new VFolder ID-based API Apr 23, 2024
@fregataa
Copy link
Member Author

fregataa commented May 9, 2024

the issue which this PR related with will be resolved in another PR after finishing refactoring query_accessible_vfolders()

@fregataa fregataa closed this May 9, 2024
@Yaminyam Yaminyam deleted the refactor/vfolder-id-based-api branch July 17, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:cli Related to CLI component comp:manager Related to Manager component size:XL 500~ LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace identification of vfolders from name to id
1 participant