Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: resize only on footer text in ads popup #1967

Merged
merged 2 commits into from
Mar 29, 2024
Merged

docs: resize only on footer text in ads popup #1967

merged 2 commits into from
Mar 29, 2024

Conversation

lizable
Copy link
Contributor

@lizable lizable commented Mar 26, 2024 •
edited by github-actions bot
Loading

Related: #1965
This PR fixes font resizing in ads footer, not in contents titles.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

📚 Documentation preview 📚: https://sorna--1967.org.readthedocs.build/en/1967/

📚 Documentation preview 📚: https://sorna-ko--1967.org.readthedocs.build/ko/1967/

@lizable lizable added the area:docs Documentations label Mar 26, 2024
@github-actions github-actions bot added the size:XS ~10 LoC label Mar 26, 2024
@achimnol achimnol added this to the 23.09 milestone Mar 26, 2024
@lizable lizable marked this pull request as ready for review March 27, 2024 07:13
@lizable lizable added this pull request to the merge queue Mar 29, 2024
Merged via the queue into main with commit 2ee3d14 Mar 29, 2024
26 checks passed
@lizable lizable deleted the docs/resize-ads-font-size-only branch March 29, 2024 05:49
kyujin-cho pushed a commit that referenced this pull request Mar 31, 2024
@lizable @kyujin-cho
docs: resize only on footer text in ads popup (#1967)
18d03d1 
Backported-from: main
Backported-to: 23.09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lizable lizable

Labels
area:docs Documentations size:XS ~10 LoC
Projects
None yet
Milestone
23.09
Development

Successfully merging this pull request may close these issues.
2 participants
@lizable @achimnol