Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Bump actions/{upload, download}-artifact from 3 to 4 #1978

Merged
merged 7 commits into from
Apr 8, 2024
Merged

ci: Bump actions/{upload, download}-artifact from 3 to 4 #1978

merged 7 commits into from
Apr 8, 2024

Conversation

Yaminyam
Copy link
Member

close #1790
close #1791

https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md
Refer to the above document and modify the artifact being uploaded with the same name.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

@Yaminyam Yaminyam requested a review from achimnol March 29, 2024 09:37
@github-actions github-actions bot added the size:M 30~100 LoC label Mar 29, 2024
@Yaminyam Yaminyam added area:infrastructure Infrastructure-related issues skip:changelog Make the action workflow to skip towncrier check and removed size:M 30~100 LoC labels Mar 29, 2024
@github-actions github-actions bot added the size:M 30~100 LoC label Mar 31, 2024
@Yaminyam Yaminyam marked this pull request as draft March 31, 2024 08:39
@github-actions github-actions bot added size:L 100~500 LoC and removed size:M 30~100 LoC labels Apr 1, 2024
@github-actions github-actions bot added size:M 30~100 LoC and removed size:L 100~500 LoC labels Apr 1, 2024
@Yaminyam Yaminyam marked this pull request as ready for review April 2, 2024 01:36
@achimnol achimnol added this to the 23.09 milestone Apr 8, 2024
@achimnol achimnol added the type:maintenance Maintenance issue. label Apr 8, 2024
@achimnol achimnol enabled auto-merge April 8, 2024 07:46
@achimnol achimnol added this pull request to the merge queue Apr 8, 2024
Merged via the queue into main with commit 20f3763 Apr 8, 2024
39 checks passed
@achimnol achimnol deleted the ci/bump-artifact branch April 8, 2024 07:49
achimnol pushed a commit that referenced this pull request Apr 8, 2024
@Yaminyam @achimnol
ci: Bump actions/{upload, download}-artifact from 3 to 4 (#1978)
0194e2b 
Backported-from: main (24.09)
Backported-to: 24.03
achimnol pushed a commit that referenced this pull request Apr 8, 2024
@Yaminyam @achimnol
ci: Bump actions/{upload, download}-artifact from 3 to 4 (#1978)
71140d1 
Backported-from: main (24.09)
Backported-to: 23.09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achimnol achimnol achimnol approved these changes

Assignees

@Yaminyam Yaminyam

Labels
area:infrastructure Infrastructure-related issues size:M 30~100 LoC skip:changelog Make the action workflow to skip towncrier check type:maintenance Maintenance issue.
Projects
None yet
Milestone
23.09
Development

Successfully merging this pull request may close these issues.
2 participants
@Yaminyam @achimnol