Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate imperative kernels table to declarative KernelRow ORM class #2309

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Jun 18, 2024

We are migrating imperative mapping to declarative mapping.
Add KernelRow declarative ORM class and leave kernels table object for compatibility

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

@github-actions github-actions bot added the comp:manager Related to Manager component label Jun 18, 2024
Copy link

graphite-app bot commented Jun 18, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@fregataa fregataa changed the title chore: Migrate KernelRow from imperative mapping to declarative mapping chore: Add declarative KernelRow ORM class Jun 20, 2024
@fregataa fregataa changed the title chore: Add declarative KernelRow ORM class chore: Migrate imperative kernels table to declarative KernelRow ORM class Jun 20, 2024
@fregataa fregataa added this to the 24.09 milestone Jun 20, 2024
@fregataa fregataa added the skip:changelog Make the action workflow to skip towncrier check label Jun 20, 2024
@fregataa fregataa marked this pull request as ready for review June 20, 2024 06:53
Copy link

graphite-app bot commented Jun 20, 2024

Merge activity

  • Jun 20, 8:11 AM EDT: The merge label 'flow:merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 20, 8:18 AM EDT: achimnol merged this pull request with the Graphite merge queue.

…ORM class (#2309)

We are migrating [imperative mapping](https://docs.sqlalchemy.org/en/20/orm/mapping_styles.html#imperative-mapping) to [declarative mapping](https://docs.sqlalchemy.org/en/20/orm/mapping_styles.html#imperative-mapping).
Add `KernelRow` declarative ORM class and leave `kernels` table object for compatibility

**Checklist:** (if applicable)

- [x] Milestone metadata specifying the target backport version
@achimnol achimnol force-pushed the topic/06-18-chore_add_kernelrow_declarative_mapping_orm_class branch from b8c37d8 to 6c2ec78 Compare June 20, 2024 12:14
@graphite-app graphite-app bot merged commit 6c2ec78 into main Jun 20, 2024
29 checks passed
@graphite-app graphite-app bot deleted the topic/06-18-chore_add_kernelrow_declarative_mapping_orm_class branch June 20, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component flow:merge-queue size:L 100~500 LoC skip:changelog Make the action workflow to skip towncrier check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants