Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Ensure referring the correct fixture file #2342

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Conversation

Yaminyam
Copy link
Member

@Yaminyam Yaminyam commented Jun 27, 2024

CleanShot 2024-06-27 at 12 57 54@2x CleanShot 2024-06-27 at 12 58 26@2x When running install-dev.sh, an error occurred in jq execution and the correct value was not entered in the env-local-{}-session.sh file. This happens because you are running jq on the wrong fixture file.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

@Yaminyam Yaminyam added this to the 24.09 milestone Jun 27, 2024
Copy link

graphite-app bot commented Jun 27, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added comp:installer Related to Installer size:S 10~30 LoC labels Jun 27, 2024
@Yaminyam Yaminyam added the skip:changelog Make the action workflow to skip towncrier check label Jun 27, 2024
@Yaminyam Yaminyam requested a review from achimnol July 10, 2024 02:09
@Yaminyam Yaminyam modified the milestones: 24.09, 23.03, 24.03 Jul 10, 2024
@achimnol achimnol modified the milestones: 24.03, 23.09 Jul 10, 2024
@achimnol achimnol merged commit 197207d into main Jul 10, 2024
26 checks passed
@achimnol achimnol deleted the chore/install-fixture branch July 10, 2024 03:46
@achimnol achimnol changed the title chore: Make sure you refer to the correct fixture file chore: Ensure referring the correct fixture file Jul 10, 2024
lablup-octodog pushed a commit that referenced this pull request Jul 10, 2024
Backported-from: main (24.09)
Backported-to: 24.03
Backport-of: 2342
lablup-octodog pushed a commit that referenced this pull request Jul 10, 2024
Backported-from: main (24.09)
Backported-to: 23.09
Backport-of: 2342
lablup-octodog added a commit that referenced this pull request Jul 10, 2024
Co-authored-by: Sion Kang <[email protected]>
Backported-from: main (24.09)
Backported-to: 24.03
Backport-of: 2342
lablup-octodog added a commit that referenced this pull request Jul 10, 2024
Co-authored-by: Sion Kang <[email protected]>
Backported-from: main (24.09)
Backported-to: 23.09
Backport-of: 2342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:installer Related to Installer size:S 10~30 LoC skip:changelog Make the action workflow to skip towncrier check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants