Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change the encoded repr of GraphQL BigInt to str #2351

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

achimnol
Copy link
Member

This PR changes the encoded representation of GraphQL BigInt to str when interacting with the frontend.
It also removes the range check as Python int can handle arbitrarily large numbers.
(Though, we may need to add checks for database LONG types.)

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

@achimnol achimnol added this to the 24.09 milestone Jun 28, 2024
@achimnol achimnol added comp:manager Related to Manager component type:enhance Enhance component, behavior, internals without user-facing features impact:invisible This change is invisible to users (internal changes). labels Jun 28, 2024
@achimnol achimnol self-assigned this Jun 28, 2024
@achimnol achimnol requested a review from yomybaby June 28, 2024 08:16
Copy link

graphite-app bot commented Jun 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the size:S 10~30 LoC label Jun 28, 2024
@achimnol achimnol force-pushed the fix/change-gql-bigint-to-encoded-as-str branch from 1f44a4e to 3b2de52 Compare July 22, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component impact:invisible This change is invisible to users (internal changes). size:S 10~30 LoC type:enhance Enhance component, behavior, internals without user-facing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant