-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Purge user after deleting records that reference the user #2374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
b6bbbbb
to
feee137
Compare
aaabc4d
to
1e4c934
Compare
15 tasks
Close this PR since #2404 will cover the same issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp:cli
Related to CLI component
comp:client
Related to Client component
comp:manager
Related to Manager component
size:L
100~500 LoC
urgency:blocker
IT SHOULD BE RESOLVED BEFORE NEXT RELEASE!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
GQL
purge_user
mutation does not work.DELETE FROM users ...
query, which violates a foreign key constraint set betweenvfolders.user
andusers.uuid
.How it changes
DELETE FROM users ...
query if the user owns vfolders where actual content remains. The mutation spawns an asynchronous task that callsDELETE FROM users ...
query after finishing deletion of vfolders.Note
The purpose of this PR is a hotfix not a refactoring or enhancement.
The changed behavior does not ensure any deletion of vfolders and as it has been, it does not show any failure of vfolder deletion.
Checklist: (if applicable)