-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(install-dev): block until DB container stabilizes #2378
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's refactor the repeated spin-wait codes as a bash function.
Co-authored-by: Joongi Kim <[email protected]> Backported-from: main (24.09) Backported-to: 23.09 Backport-of: 2378
Co-authored-by: Joongi Kim <[email protected]> Backported-from: main (24.09) Backported-to: 24.03 Backport-of: 2378
Co-authored-by: Sion Kang <[email protected]> Co-authored-by: Joongi Kim <[email protected]>
Co-authored-by: Sion Kang <[email protected]> Co-authored-by: Joongi Kim <[email protected]>
When starting codespace, redis-related settings are not being put into etcd.
Since other etcd put requests were processed normally, it is expected that the problem occurred because the put request was executed before etcd was ready.
So, after performing a health check of the halfstack service, proceed to the next step.
When using install-dev.sh in the provisioning stage, such as codespace, script execution may be faster than executing docker daemon.
The script runs after the docker daemon's health check.
Checklist: (if applicable)