Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect check of values returned from docker stat API #2389

Merged
merged 4 commits into from
Jul 13, 2024

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Jul 5, 2024

image

I guess this started to happen after aiodocker 0.22.0 version

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

@fregataa fregataa added this to the 24.09 milestone Jul 5, 2024
@fregataa fregataa self-assigned this Jul 5, 2024
Copy link

graphite-app bot commented Jul 5, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added comp:agent Related to Agent component size:S 10~30 LoC labels Jul 5, 2024
@fregataa fregataa modified the milestones: 24.09, 24.03 Jul 11, 2024
@fregataa fregataa changed the title fix: Wrong handling the return value of docker stat api fix: incorrect check of values returned from docker stat API Jul 11, 2024
@fregataa fregataa marked this pull request as ready for review July 11, 2024 06:58
@fregataa fregataa requested a review from achimnol July 11, 2024 06:58
@fregataa fregataa requested a review from kyujin-cho July 12, 2024 14:56
@fregataa fregataa added the urgency:4 As soon as feasible, implementation is essential. label Jul 12, 2024
@achimnol achimnol added this pull request to the merge queue Jul 13, 2024
Merged via the queue into main with commit 8807eaa Jul 13, 2024
39 checks passed
@achimnol achimnol deleted the fix/wrong-handling-return-value-of-docker-stat-api branch July 13, 2024 15:07
kyujin-cho pushed a commit that referenced this pull request Jul 16, 2024
Backported-from: main (24.09)
Backported-to: 24.03
Backport-of: 2389
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:agent Related to Agent component size:S 10~30 LoC urgency:4 As soon as feasible, implementation is essential.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants