Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Immediately move vfolders to trash bin when purging user #2405

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

achimnol
Copy link
Member

@achimnol achimnol commented Jul 8, 2024

refs #2376

Move all vfolders when purging a user, instead of triggering immediate storage-level deletion.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

Copy link

graphite-app bot commented Jul 8, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

achimnol commented Jul 8, 2024

@github-actions github-actions bot added comp:manager Related to Manager component size:M 30~100 LoC labels Jul 8, 2024
@achimnol achimnol force-pushed the topic/move-vfolders-to-trash-bin-when-deleting-user branch from aac063c to 72a1cac Compare July 8, 2024 14:20
@achimnol achimnol added type:enhance Enhance component, behavior, internals without user-facing features urgency:4 As soon as feasible, implementation is essential. labels Jul 8, 2024
@achimnol achimnol force-pushed the topic/remove-users-vfolders-freignkey branch from ed27ce0 to 0c35a76 Compare July 8, 2024 15:42
@achimnol achimnol force-pushed the topic/move-vfolders-to-trash-bin-when-deleting-user branch from 72a1cac to 9b2044f Compare July 8, 2024 15:43
@achimnol achimnol force-pushed the topic/move-vfolders-to-trash-bin-when-deleting-user branch from 9b2044f to ffef060 Compare July 8, 2024 15:50
@achimnol achimnol added this to the 24.03 milestone Jul 8, 2024
@achimnol achimnol marked this pull request as ready for review July 8, 2024 15:52
@achimnol achimnol requested a review from fregataa July 8, 2024 15:57
@achimnol achimnol force-pushed the topic/remove-users-vfolders-freignkey branch from 53f34cb to 82b47f2 Compare July 9, 2024 08:31
@achimnol achimnol changed the base branch from topic/remove-users-vfolders-freignkey to main July 9, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component size:M 30~100 LoC type:enhance Enhance component, behavior, internals without user-facing features urgency:4 As soon as feasible, implementation is essential.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant