Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: image configuration when create kernels #2646

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Aug 5, 2024

ai.backend.common.types.ImageRegistry is image registry info.
ai.backend.common.types.ImageConf contains image information to use when creating kernels including image reference and image registry.

Use both types to create kernels.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • API server-client counterparts (e.g., manager API -> client SDK)

@github-actions github-actions bot added comp:manager Related to Manager component comp:agent Related to Agent component comp:common Related to Common component labels Aug 5, 2024
Copy link
Member Author

fregataa commented Aug 5, 2024

@github-actions github-actions bot added the size:L 100~500 LoC label Aug 5, 2024
@fregataa fregataa added the skip:changelog Make the action workflow to skip towncrier check label Aug 5, 2024
@fregataa fregataa force-pushed the topic/06-18-feature_add_session_status_checker_api branch from 671e3e3 to 1454510 Compare August 10, 2024 13:22
@fregataa fregataa force-pushed the topic/08-01-refactor_clean_image_configuration_when_create_kernels branch 2 times, most recently from b00e29a to d741b8e Compare August 10, 2024 16:10
@fregataa fregataa added this to the 24.09 milestone Aug 10, 2024
@fregataa fregataa force-pushed the topic/06-18-feature_add_session_status_checker_api branch from 1454510 to 4de0976 Compare August 11, 2024 01:37
@fregataa fregataa force-pushed the topic/08-01-refactor_clean_image_configuration_when_create_kernels branch from d741b8e to b64b91e Compare August 11, 2024 01:37
@fregataa fregataa force-pushed the topic/06-18-feature_add_session_status_checker_api branch from 4de0976 to a782f89 Compare August 11, 2024 02:19
@fregataa fregataa force-pushed the topic/08-01-refactor_clean_image_configuration_when_create_kernels branch from b64b91e to b756418 Compare August 11, 2024 02:19
@fregataa fregataa force-pushed the topic/06-18-feature_add_session_status_checker_api branch from a782f89 to 81894a7 Compare August 11, 2024 06:05
@fregataa fregataa force-pushed the topic/08-01-refactor_clean_image_configuration_when_create_kernels branch from b756418 to e400d7d Compare August 11, 2024 06:05
@fregataa fregataa force-pushed the topic/06-18-feature_add_session_status_checker_api branch from 81894a7 to b792079 Compare August 16, 2024 05:48
@fregataa fregataa force-pushed the topic/08-01-refactor_clean_image_configuration_when_create_kernels branch from e400d7d to 60e1295 Compare August 16, 2024 05:49
@fregataa fregataa force-pushed the topic/06-18-feature_add_session_status_checker_api branch from b792079 to b7f8ee7 Compare August 19, 2024 10:55
@fregataa fregataa force-pushed the topic/08-01-refactor_clean_image_configuration_when_create_kernels branch from 60e1295 to 1b81afa Compare August 19, 2024 10:55
@fregataa fregataa force-pushed the topic/06-18-feature_add_session_status_checker_api branch from b7f8ee7 to 52c7dc1 Compare August 25, 2024 06:36
@fregataa fregataa force-pushed the topic/08-01-refactor_clean_image_configuration_when_create_kernels branch from 07a554c to 725ac55 Compare August 31, 2024 16:16
@fregataa fregataa force-pushed the topic/06-18-feature_add_session_status_checker_api branch from a9f2dda to dd77d5a Compare September 1, 2024 08:50
@fregataa fregataa force-pushed the topic/08-01-refactor_clean_image_configuration_when_create_kernels branch from 725ac55 to 84ef131 Compare September 1, 2024 08:51
@fregataa fregataa changed the title refactor: Clean image configuration when create kernels refactor: image configuration when create kernels Sep 1, 2024
@fregataa fregataa force-pushed the topic/06-18-feature_add_session_status_checker_api branch from 5d751d8 to 966c737 Compare September 1, 2024 13:50
@fregataa fregataa force-pushed the topic/08-01-refactor_clean_image_configuration_when_create_kernels branch from 6cbb662 to 76bdccd Compare September 1, 2024 13:50
@fregataa fregataa force-pushed the topic/06-18-feature_add_session_status_checker_api branch from 966c737 to 063a382 Compare September 2, 2024 07:57
@fregataa fregataa force-pushed the topic/08-01-refactor_clean_image_configuration_when_create_kernels branch from 76bdccd to e84a427 Compare September 2, 2024 07:57
@fregataa fregataa force-pushed the topic/06-18-feature_add_session_status_checker_api branch from fcc097c to 5157770 Compare September 2, 2024 08:25
@fregataa fregataa force-pushed the topic/08-01-refactor_clean_image_configuration_when_create_kernels branch from ede5b19 to b02cad9 Compare September 2, 2024 08:25
@fregataa fregataa force-pushed the topic/06-18-feature_add_session_status_checker_api branch 2 times, most recently from b5aef12 to f6b166e Compare September 5, 2024 00:47
@fregataa fregataa force-pushed the topic/08-01-refactor_clean_image_configuration_when_create_kernels branch from b02cad9 to 89f43a2 Compare September 5, 2024 00:47
@fregataa fregataa force-pushed the topic/06-18-feature_add_session_status_checker_api branch 5 times, most recently from c1b992a to 87ea9ff Compare September 14, 2024 05:16
Base automatically changed from topic/06-18-feature_add_session_status_checker_api to main September 14, 2024 05:24
@fregataa fregataa force-pushed the topic/08-01-refactor_clean_image_configuration_when_create_kernels branch 2 times, most recently from cee129f to de849cf Compare September 14, 2024 12:12
@fregataa fregataa marked this pull request as ready for review September 14, 2024 12:15
@fregataa fregataa force-pushed the topic/08-01-refactor_clean_image_configuration_when_create_kernels branch from de849cf to 1a5302a Compare September 14, 2024 12:44
@fregataa fregataa added this pull request to the merge queue Sep 14, 2024
Merged via the queue into main with commit 3212918 Sep 14, 2024
25 checks passed
@fregataa fregataa deleted the topic/08-01-refactor_clean_image_configuration_when_create_kernels branch September 14, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:agent Related to Agent component comp:common Related to Common component comp:manager Related to Manager component size:L 100~500 LoC skip:changelog Make the action workflow to skip towncrier check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant