Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Vietnamese translation #2855

Closed
wants to merge 1 commit into from

Conversation

nghiahsgs
Copy link

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

Copy link

cla-assistant bot commented Sep 22, 2024

CLA assistant check
All committers have signed the CLA.

@rapsealk
Copy link
Member

Thank you for your contribution.

However, please note that we manage the web-related files (located under src/ai/backend/web/static) in a separate repository. The file you modified is a clone of the original file found at https://github.com/lablup/backend.ai-webui/blob/main/resources/i18n/vi.json.

We would greatly appreciate it if you could submit a new pull request to https://github.com/lablup/backend.ai-webui. Thank you for your understanding.

@nghiahsgs
Copy link
Author

Thank you for your contribution.

However, please note that we manage the web-related files (located under src/ai/backend/web/static) in a separate repository. The file you modified is a clone of the original file found at https://github.com/lablup/backend.ai-webui/blob/main/resources/i18n/vi.json.

We would greatly appreciate it if you could submit a new pull request to https://github.com/lablup/backend.ai-webui. Thank you for your understanding.

Thank for your information ! I created new PR for UI here:
lablup/backend.ai-webui#2716

@rapsealk
Copy link
Member

rapsealk commented Oct 4, 2024

Superseded by lablup/backend.ai-webui#2716.

@rapsealk rapsealk closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants