-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Improve container registries migration script #2888
Open
jopemachine
wants to merge
8
commits into
main
Choose a base branch
from
fix/wrong-container-registries-migration-script
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jopemachine
added
type:bug
Reports about that are not working
require:db-migration
Automatically set when alembic migrations are added or updated
labels
Oct 2, 2024
jopemachine
added
the
skip:ci
Make the action workflow to skip running lint, check, and test (use with caution!)
label
Oct 2, 2024
…exists for the image canonical name.
jopemachine
force-pushed
the
fix/wrong-container-registries-migration-script
branch
from
October 3, 2024 10:06
c420fd8
to
2274fc8
Compare
jopemachine
added
the
skip:changelog
Make the action workflow to skip towncrier check
label
Oct 3, 2024
jopemachine
changed the title
fix: Wrong container registries migration script
fix: Improve container registries migration script
Oct 3, 2024
achimnol
requested changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still it fails:
File "/home/joongi/bai-edge/src/ai/backend/manager/models/alembic/versions/1d42c726d8a3_migrate_container_registries_from_etcd_to_psql.py", line 457, in upgrade
insert_registry_id_to_images_with_black_registry_id()
File "/home/joongi/bai-edge/src/ai/backend/manager/models/alembic/versions/1d42c726d8a3_migrate_container_registries_from_etcd_to_psql.py", line 381, in insert_registry_id_to_images_with_black_registry_id
registry_info = dict(registry_info)
^^^^^^^^^^^^^^^^^^^
TypeError: 'NoneType' object is not iterable
...nager/models/alembic/versions/1d42c726d8a3_migrate_container_registries_from_etcd_to_psql.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
require:db-migration
Automatically set when alembic migrations are added or updated
skip:changelog
Make the action workflow to skip towncrier check
skip:ci
Make the action workflow to skip running lint, check, and test (use with caution!)
type:bug
Reports about that are not working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #1917.
downgrade()
due to the absence of theextra
column in the Image table.upgrade()
to automatically generate the corresponding container registry row instead of raising an error when no container registry exists for the image canonical name.example
Checklist: (if applicable)