Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Disallow None id encoding in AsyncNode.to_global_id() (#2898) #2956

Merged
merged 1 commit into from
Oct 24, 2024
Merged

fix: Disallow None id encoding in AsyncNode.to_global_id() (#2898) #2956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/2898.fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Disallow `None` id encoding in `AsyncNode.to_global_id()`.
6 changes: 4 additions & 2 deletions src/ai/backend/manager/models/gql_relay.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,10 @@ async def node_resolver(cls, only_type, root, info, id):
return await cls.get_node_from_global_id(info, id, only_type=only_type)

@staticmethod
def to_global_id(type_, id) -> str:
return base64(f"{type_}:{id}")
def to_global_id(type_, id_) -> str:
if id_ is None:
raise Exception("Encoding None value as Global ID is not allowed.")
return base64(f"{type_}:{id_}")

@classmethod
def resolve_global_id(cls, info, global_id: str) -> tuple[str, str]:
Expand Down
Loading