Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle IndexError when parse BinarySize (#2962) #2964

Merged
merged 1 commit into from
Oct 24, 2024
Merged

fix: Handle IndexError when parse BinarySize (#2962) #2964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/2962.fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Handle `IndexError` when parse string to `BinarySize`
4 changes: 2 additions & 2 deletions src/ai/backend/common/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,8 +529,8 @@ def _parse_str(cls, expr: str) -> Union[BinarySize, Decimal]:
# has no suffix and is not an integer
# -> fractional bytes (e.g., 1.5 byte)
raise ValueError("Fractional bytes are not allowed")
except ArithmeticError:
raise ValueError("Unconvertible value", orig_expr)
except (ArithmeticError, IndexError):
raise ValueError("Unconvertible value", orig_expr, ending)
try:
multiplier = cls.suffix_map[suffix]
except KeyError:
Expand Down
Loading