Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow admins to delete other user's vfolders #3137

Merged
merged 3 commits into from
Nov 28, 2024
Merged

fix: Allow admins to delete other user's vfolders #3137

merged 3 commits into from
Nov 28, 2024

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Nov 26, 2024 •
edited by github-actions bot
Loading

resolves https://github.com/lablup/giftbox/issues/773

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • API server-client counterparts (e.g., manager API -> client SDK)

📚 Documentation preview 📚: https://sorna--3137.org.readthedocs.build/en/3137/

📚 Documentation preview 📚: https://sorna-ko--3137.org.readthedocs.build/ko/3137/

@fregataa fregataa added this to the 24.03 milestone Nov 26, 2024
@fregataa fregataa self-assigned this Nov 26, 2024
@github-actions github-actions bot added area:docs Documentations comp:manager Related to Manager component size:S 10~30 LoC labels Nov 26, 2024
@fregataa fregataa changed the title fix: Allow admins to delete others vfolder fix: Enable admins to delete other user's vfolders Nov 26, 2024
@fregataa fregataa changed the title fix: Enable admins to delete other user's vfolders fix: Allow admins to delete other user's vfolders Nov 26, 2024
@fregataa fregataa added the urgency:5 It is imperative that action be taken right away. label Nov 26, 2024
@fregataa fregataa requested a review from jopemachine November 28, 2024 06:02
@jopemachine jopemachine mentioned this pull request Nov 28, 2024
Open
@fregataa fregataa added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit a4c9ab2 Nov 28, 2024
36 checks passed
@fregataa fregataa deleted the fix/allow-admin-delete-others-folder branch November 28, 2024 06:14
fregataa added a commit that referenced this pull request Nov 28, 2024
@fregataa
fix: Allow admins to delete other user's vfolders (#3137)
96d3cf7 
Backported-from: main (24.12)
Backported-to: 24.09
Backport-of: 3137
@fregataa fregataa mentioned this pull request Nov 28, 2024
Merged
fregataa added a commit that referenced this pull request Nov 28, 2024
@fregataa
fix: Allow admins to delete other user's vfolders (#3137)
990d479 
Backported-from: main (24.12)
Backported-to: 24.03
Backport-of: 3137
@fregataa fregataa mentioned this pull request Nov 28, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 28, 2024
@fregataa
fix: Allow admins to delete other user's vfolders (#3137) (#3160)
8f77353
github-merge-queue bot pushed a commit that referenced this pull request Nov 28, 2024
@fregataa
fix: Allow admins to delete other user's vfolders (#3137) (#3161)
ba9a96c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoyajigi hoyajigi Awaiting requested review from hoyajigi

@adrysn adrysn Awaiting requested review from adrysn

@kmkwon94 kmkwon94 Awaiting requested review from kmkwon94

@jopemachine jopemachine Awaiting requested review from jopemachine

Assignees

@fregataa fregataa

Labels
area:docs Documentations comp:manager Related to Manager component size:S 10~30 LoC urgency:5 It is imperative that action be taken right away.
Projects
None yet
Milestone
24.03
Development

Successfully merging this pull request may close these issues.
2 participants
@fregataa @jopemachine