Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made changes for M2 mac support #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

RobJY
Copy link

@RobJY RobJY commented Jan 31, 2023

I've updated package versions in requirements.yml to use conda packages available to M2 macs. Because of an update to flask-sqlalchemy it also required a one-line change to minerva_analysis/server/models/database_model.py. This is explained in the following link:
https://stackoverflow.com/questions/73961938/flask-sqlalchemy-db-create-all-raises-runtimeerror-working-outside-of-applicat

@RobJY
Copy link
Author

RobJY commented Jan 31, 2023

I tested on my home Ubuntu 22.04 desktop at it seems to run fine.

@jmuhlich
Copy link
Contributor

I found a less invasive change set that doesn't require touching the app code. Rob can you verify whether this works for you too? Here are just the few dependency specs I changed. I also removed the pip section entirely since opencv is available in conda-forge (I got some missing library errors from the pip-installed opencv-python wheel on my mac, anyway, so that wasn't even usable).

- python
- sqlalchemy<2
- opencv=4.5.3

@RobJY
Copy link
Author

RobJY commented Apr 13, 2023

Yes, that works for me on my M2 laptop. You're right, that's better than modifying existing code. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants