Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration: add basic clipboard manager integration #58

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

01micko
Copy link

@01micko 01micko commented Aug 8, 2024

references labwc/labwc#2042

@xi
Copy link

xi commented Aug 8, 2024

I think there are two very different concerns here:

  1. Users don't expect the clipboard to be lost when an application closes. This will affect (and probably annoy) most users. So it should be explained first and a simple, succinct solution should be provided.
  2. Some users like to have more advanced clipboard managers that save a history and offer their own UI. These users generally don't expect this feature to just be there and therefore will actively search for it.

As far as I understand, your text is currently more geared towards the second group. Technically, it also solves the issue for the first group, but it is far more than what they want or expect. So the documentation of the proposed tools is more overwhelming than helpful.

@01micko
Copy link
Author

01micko commented Aug 8, 2024

@xi

While I agree with you about the first and second sentences of your first point, it is not only labwc in the wayland world that has this behaviour.


What is not simple about ..

Labwc does not natively support storing of data kept on the clipboard.
For this functionality you need a clipboard manager.

The documentation I have written is meant as a guide only with relevant links. I don't think the page should have full explanations on every tool available for the job. Aside from that, each distro may have different packages, so I think full explanations should be part of distro documentation.

I've already slightly biased cliphist, as written in the autostart example and if anything, that's what I would be willing to change.

@xi
Copy link

xi commented Aug 8, 2024

I was not meaning to propose that every available tool should be explained. I was merely suggesting to restructure the text to focus on the more common pain point:

Labwc does not store clipboard contents after an application quits. For this functionality you need a clipboard manager.

For example, you could add a line similar to this to ~/.config/labwc/autostart:

wl-paste --watch cliphist store &

This uses [cliphist] and [wl-clipboard]. Other clipboard managers include [clapboard] and [clipse].

Many clipboard managers have features beyond just keeping the clipboard alive. See the documentation of the individual tools for further information.

@xi
Copy link

xi commented Aug 8, 2024

To be clear, I don't actually like this solution. I think that it is strange to delegate such a crucial feature to external programs. It is also unfortunate that most clipboard managers suffer from feature creep. Some clipboard managers don't even have a mechanism to limit the number of history entries, which can quickly turn into a security issue. There is simply no good solution right now. But it is better to document a half-decent one than to let users try to figure this out for themselves.

@01micko
Copy link
Author

01micko commented Aug 8, 2024

@xi your comments are fair, but I fully understand why labwc refuses to manage the clipboard. In the X world there are a multitude of clipboard managers as well, many probably worse than what we have in wayland.

I'll take your advice on board about re-wording my PR but I'll wait for further review from maintainers before I change anything.

Thanks :)

@Consolatis
Copy link
Member

I was not meaning to propose that every available tool should be explained. I was merely suggesting to restructure the text to focus on the more common pain point:

Labwc does not store clipboard contents after an application quits. For this functionality you need a clipboard manager.
For example, you could add a line similar to this to ~/.config/labwc/autostart:

wl-paste --watch cliphist store &

This uses [cliphist] and [wl-clipboard]. Other clipboard managers include [clapboard] and [clipse].
Many clipboard managers have features beyond just keeping the clipboard alive. See the documentation of the individual tools for further information.

I like this variant, the current text might make users wonder if they need a clipboard manager or not while this one specifically mentions it being a solution to keep clipboard data after application close. I think this helps the user to evaluate the necessity of a clipboard manager and what might be problematic when running without one.

@johanmalm
Copy link
Contributor

@01micko Thanks.

I like this variant, the current text might make users wonder if they need a clipboard manager or not while this one specifically mentions it being a solution to keep clipboard data after application close. I think this helps the user to evaluate the necessity of a clipboard manager and what might be problematic when running without one.

Agree. @01micko if you're happy to update with this, we'll go for the merge.

@01micko
Copy link
Author

01micko commented Aug 8, 2024

I'll update the PR tonight AEST.
Many thanks @Consolatis , @johanmalm and @xi for feedback.

@01micko
Copy link
Author

01micko commented Aug 8, 2024

I just read through labwc/labwc/issues/2042

I won't have time to write up a page so I understand if this is closed.

@Consolatis
Copy link
Member

I won't have time to write up a page so I understand if this is closed.

No need for you to do that, I think the changes as proposed here are already very useful for users. We can always add a new page later on and then link it from the new section.

@01micko 01micko force-pushed the integration/clipboard branch from 7c299c3 to e01387c Compare August 9, 2024 08:34
@Consolatis Consolatis merged commit 9154384 into labwc:main Aug 9, 2024
@Consolatis
Copy link
Member

Thanks :)

@01micko 01micko deleted the integration/clipboard branch August 9, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants