Add command to skip without downvoting #17
Conversation
| send message, response | ||
| end | ||
|
|
||
| hear ~r/^dj\s(what|who).*\snext$/i, message do |
There was a problem hiding this comment.
This call is not in the help, and its regex is too generic.
There was a problem hiding this comment.
I've added help for this command. As far as the regex being too generic, I've reused what's already there for what/who's playing. We can create a new issue for being more specific in both commands if desired
There was a problem hiding this comment.
I don't see why we'd want to repeat the sins of our ancestors on new code.
| `dj (what|who) ('s| is) playing` displays the currently playing track and playlist (e.g. what's playing or who is playing) | ||
| `dj +1|:thumbsup:|:thumbsup_all:|:metal:|:shaka:|up|yes` upvotes if you like the currently playing track on the currently playing playlist | ||
| `dj -1|:thumbsdown:|:thumbsdown_all:|down|no|skip|next` votes against the currently playing track on the currently playing playlist and skips to the next track | ||
| `dj who's playing` or what's playing, shows track and playlist |
There was a problem hiding this comment.
The old documentation is correct, this looses other supported requests.
There was a problem hiding this comment.
Emojis are not rendered within backticks, so we should either get rid of the code-formatted help or avoid specifying emoji. Here I've chosen the latter.
I would argue that a global help that shows all possible forms of every command is not that helpful and just becomes difficult to read.
| response = with {:ok, level} <- Mixer.get_volume do | ||
| "The volume level is set to #{round(level/10)}" | ||
| end | ||
| send message, response | ||
| end | ||
|
|
||
| hear ~r/^dj\svolume\s(?<level>.*)$/i, message do | ||
| hear ~r/^dj\svol(ume)?\s(?<level>.*)$/i, message do |
There was a problem hiding this comment.
Should be included in the help.
There was a problem hiding this comment.
Do we really need to tip the reader that they can either spell out volume or not? It should do the same thing
|
Closes #3 |
Also "what's next", cleans up some help, minor refactoring