Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/additional fields #62

Merged
merged 6 commits into from
Sep 23, 2023
Merged

Fix/additional fields #62

merged 6 commits into from
Sep 23, 2023

Conversation

eum602
Copy link
Member

@eum602 eum602 commented Sep 23, 2023

Pull request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Link: N/A

What is the new behavior?

  • Add PoE for emitted credentials.
  • Add configuration variable PROOF_OF_EXISTENCE_MODE to set PoE mode:
    • DISABLED: Proof of existence is disabled, in the respose the field TxHash is set to null
    • STRICT: Proof of existence must strictly succeed otherwise the request throws and in the respose the field TxHash is set to null, otherwise that field will have a valid transaction hash
    • ENABLED_NOT_THROWABLE: If Proof of existence fails the request does not throw but in the respose the field TxHash is set to null, otherwise that field will have a valid transaction hash
  • Updates verification registry to '0xF17Da8641771c0196318515b662b0C00132C4163' which by default uses
    didRegistry: 0x43dE0954a2c83A415d82b9F31705B969b5856003
  • Considers certificate period fields (if defined) as the verifiable credential issuance/expiration dates
  • Add additional fields
  • validates mandatory and optional DDCCCoreDataSet fields
  • Downgrades ethers to version 5.6.5 since it was needed to use GasModel Library.

Other information

N/A

Preview

N/A

@eum602 eum602 merged commit b7e427d into master Sep 23, 2023
1 of 2 checks passed
@eum602 eum602 deleted the fix/additional-fields branch September 23, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant